Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ClimateMappedAfrica Fix Zoom Bug #1000

Merged
merged 6 commits into from
Nov 14, 2024
Merged

ClimateMappedAfrica Fix Zoom Bug #1000

merged 6 commits into from
Nov 14, 2024

Conversation

kelvinkipruto
Copy link
Contributor

@kelvinkipruto kelvinkipruto commented Nov 14, 2024 •
edited
Loading

Description

This PR fixes a bug in ClimateMapped where the map zoom level was not included in the rootGeography configuration

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@kelvinkipruto
Update workflow
a5fb968 
Signed-off-by: Kipruto <[email protected]>
@kelvinkipruto
Include zoom
061ed65 
Signed-off-by: Kipruto <[email protected]>
@kelvinkipruto
Revert workflow file
4ad0ff2 
Signed-off-by: Kipruto <[email protected]>
@kelvinkipruto kelvinkipruto changed the title ClimateMappedAfrica ARM Build ClimateMappedAfrica Fix Zoom Bug Nov 14, 2024
@kelvinkipruto kelvinkipruto marked this pull request as ready for review November 14, 2024 11:09
koechkevin
koechkevin reviewed Nov 14, 2024
View reviewed changes
Copy link
Contributor

@koechkevin koechkevin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did this get lost @kelvinkipruto ?

@kelvinkipruto
Copy link
Contributor Author

@koechkevin PR #991 deleted the RootGeography file where these changes had been made. When merging #996, I did not crosscheck that further modifications had been made to that file.

@kilemensi
Copy link
Member

If it's a fix, don't wait for my approval, lets get it deployed @kelvinkipruto

@kelvinkipruto kelvinkipruto added this pull request to the merge queue Nov 14, 2024
Merged via the queue into main with commit f4e0b0c Nov 14, 2024
4 checks passed
@kelvinkipruto kelvinkipruto deleted the ft/climatemapped-arm-build branch November 14, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koechkevin koechkevin koechkevin approved these changes

@kilemensi kilemensi Awaiting requested review from kilemensi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kelvinkipruto @kilemensi @koechkevin